Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-sdk-s3-persistence-adapter, aws-sdk-dynamodb-persistence-adapter): upgrade dynamodb and s3 persistence adapters to use AWS SDK v3 #699

Draft
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from

Conversation

sam-goodwin
Copy link

@sam-goodwin sam-goodwin commented Oct 27, 2021

Closes #697
Closes #696

This change refactors the S3 and DynamoDB persistence adapters to use AWS SDK v3.

…pter): upgrade dynamodb and s3 persistence adapters to use AWS SDK v3
@paul-uz
Copy link

paul-uz commented Oct 27, 2021

Does this remove the dependency for the v2 AWS SDK fully, and make it fully v3 compatible?

@sam-goodwin
Copy link
Author

Yes, i removed it from s3 and dynamo db adapter packages.

@doiron doiron added the dependencies Pull requests that update a dependency file label Apr 28, 2022
@doiron doiron requested review from doiron and removed request for ShenChen93 April 28, 2022 20:49
@jheym
Copy link

jheym commented May 5, 2023

image

@paul-uz
Copy link

paul-uz commented May 8, 2023

Can we get this merged in yet? It's been 2 years...

@sam-goodwin
Copy link
Author

Can we get this merged in yet? It's been 2 years...

I no longer work at Amazon, sorry. Hopefully someone from the SDK team can help you out.

@doiron doiron removed their request for review May 15, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file investigating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3 Javascript SDK compatibility? Request: Migrate DynamoDbPersistenceAdapter to AWS SDK v3 and save 60Mb
4 participants