Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [REQUEST] Navidrome #1409

Closed
2 tasks done
baldarn opened this issue May 22, 2024 · 24 comments
Closed
2 tasks done

✨ [REQUEST] Navidrome #1409

baldarn opened this issue May 22, 2024 · 24 comments
Labels
automerge Auto Merge PR enhancement New feature or request prevent stale Prevents stale being applied

Comments

@baldarn
Copy link
Contributor

baldarn commented May 22, 2024

Checked

  • If a new addon, I have checked on Google that such as addon doesn't already exists
  • If a new feature, I have searched in the discussions & issues that it was not already covered

Which addon?

Navidrome
https://github.com/navidrome/navidrome/

Is your feature request related to a problem? Please describe

just want to add this

someone tried to use that, but with no luck

navidrome/navidrome#2605

Describe the solution you'd like

add the addon

@baldarn baldarn added enhancement New feature or request prevent stale Prevents stale being applied labels May 22, 2024
@baldarn
Copy link
Contributor Author

baldarn commented May 22, 2024

will try to take care of it

@baldarn
Copy link
Contributor Author

baldarn commented May 22, 2024

@alexbelgium same problem with the image for navidrome... i fell unlucky ;(

@baldarn baldarn closed this as completed May 22, 2024
@baldarn baldarn reopened this May 22, 2024
@alexbelgium
Copy link
Owner

@alexbelgium same problem with the image for navidrome... i fell unlucky ;(

What problem do you mean?

@baldarn
Copy link
Contributor Author

baldarn commented May 22, 2024

the image is not present
Screenshot_20240522_164920

@alexbelgium
Copy link
Owner

mmh I'll push it

@hiagocosta
Copy link

I have a question about navidrome...
is it possible that I can change music folder to a SMB NAS, just like we can make with other addons?

alexbelgium added a commit that referenced this issue May 29, 2024
@alexbelgium
Copy link
Owner

alexbelgium commented May 29, 2024

Added the link to mount smb or local drives in /mnt

@alexbelgium
Copy link
Owner

Mmh indeed the image doesn't build but I can't understand what is wrong. Are the files formatted with lf and not crlf?

@hiagocosta
Copy link

I just changed TZ viriable and my addon doens't start

after checking the logs I see:

Starting...
/etc/cont-init.d/00-banner.sh: executing

-----------------------------------------------------------
 Add-on: Navidrome
 Navidrome for Home Assistant
-----------------------------------------------------------
 Add-on version: 0.52.5-2
 You are running the latest version of this add-on.
 System: Home Assistant OS 12.3  (amd64 / generic-x86-64)
 Home Assistant Core: 2024.5.5
 Home Assistant Supervisor: 2024.05.1
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums
-----------------------------------------------------------
 Provided by: https://github.com/alexbelgium/hassio-addons 
-----------------------------------------------------------
/etc/cont-init.d/00-global_var.sh: executing
/etc/cont-init.d/01-config_yaml.sh: executing
Setting permissions for the config.yaml directory

Load environment variables from /config/config.yaml if existing
If accessing the file with filebrowser it should be mapped to /addon_configs/db21ed7f-navidrome/config.yaml
---------------------------------------------------------
Wiki here on how to use : github.com/alexbelgium/hassio-addons/wiki/Add‐ons-feature-:-add-env-variables

TZ='America/Sao_Paulo'
/etc/cont-init.d/01-custom_script.sh: executing
Execute /addon_configs/db21ed7f-navidrome/navidrome.sh if existing
Wiki here : github.com/alexbelgium/hassio-addons/wiki/Add-ons-feature-:-customisation
 
Starting the upstream container

@bilogic
Copy link
Contributor

bilogic commented May 30, 2024

Navidrome works if it is loaded standalone, it does not work if we try to load in HA's iframe (ingress).

To keep it simple, if we can set ND_BASEURL to ., that should fix it, currently navidrom panics.

@hiagocosta
Copy link

I have to add ND_BASEURL as a variable?

@bilogic
Copy link
Contributor

bilogic commented May 31, 2024

I have to add ND_BASEURL as a variable?

Yes, but that is still not going to make things work. See navidrome/navidrome#2605

@hiagocosta
Copy link

i'm still unable to run this addon, any plans to update?
it keeps start and return back

@baldarn
Copy link
Contributor Author

baldarn commented Jun 7, 2024

hi @hiagocosta , will try to fix this next week

@alexbelgium
Copy link
Owner

hi @hiagocosta , will try to fix this next week

Thanks! Sorry I don't have much time to look for the moment but don't hesitate if you need any support for specific elements

@baldarn
Copy link
Contributor Author

baldarn commented Jun 13, 2024

trying something

@alexbelgium the image is not built.. I think that / automerge doens't trigger that.. or something different happens :/
ps: could we exchange telegram/some-realtime-communication-app to find each other realtime? ;)

could you have a look?

@github-actions github-actions bot added the automerge Auto Merge PR label Jun 13, 2024
@alexbelgium
Copy link
Owner

Argh indeed it seems automerge doesn't work but I don't understand why... I'll have a look!

If you want I'll try to look at the code tomorrow to see if I can find something :)

@alexbelgium
Copy link
Owner

alexbelgium commented Jun 13, 2024

Are you on HA community forum? They accept PM and we can exchange details there

@celynw
Copy link

celynw commented Jun 13, 2024

I have an addons repository with Navidrome, in case it's of any help.

I did base most of it on @alexbelgium's amazing work, after all

(EDIT: Why did I get a notification for a failed run caused by me simply making this comment..?)

@alexbelgium
Copy link
Owner

alexbelgium commented Jun 14, 2024

Hi celynw, very nice work! Glad to see that what I did can be useful to others also - the community lives on inspiring ourselves from other's work and taking it further! At my start, most of my repo was inspired by https://github.com/petersendev/hassio-addons ;-)

The failed run is due to an automerge workflow that is not working ;-) long story short I wanted to find a way for "external" users to trigger a build so they could "host" their addons on my repo but still be fully autonomous in coding & building. As such, in theory the / automerge tag should trigger an automatic merge of the PR on which it is written as a comment. However, the workflow stopped working and is now sending failed runs to everyone until I have time to correct that ;-)

@baldarn
Copy link
Contributor Author

baldarn commented Jun 14, 2024

@celynw I was adding this addon just for fun

would you like to merge yours in this collection? that would benefit the community ;)

what do you think @alexbelgium ?

@celynw
Copy link

celynw commented Jun 14, 2024

For my repo, I had trouble understanding how some of the extra parts worked - The templates, bashio, S6... I also felt that I didn't need much of the CI, so I made an effort to simplify things. Although I think Navidrome itself works perfectly for me, there would be some work in making it consistent with this repository.

Worth mentioning again @bilogic has a repo too!

Mine is different in these ways:

  • Exposes more of the config to HA
    • Adds descriptions to each option by using translations
  • Builds for ARM (1-line change)
  • Follows same versioning and changelog as upstream Navidrome, rather than announcing changes to the addon itself
  • Removed some of the CI/template stuff
  • No proxy stuff (I do this externally)

I have a feeling that it would be easier to merge from @bilogic's one mentioned in #789, and maybe we could enable builds for ARM and add more documentation/config options as I did?

@alexbelgium
Copy link
Owner

Hi guys, as you want! I've put the extra parts to simplify working on several addons - I just need to change a file to update all addons ;-)

The key thing is that it works... I don't necessarily want to merge as you can keep more flexibility (and personal recognition) by having your own repo, but if you want I am not against it ! An hybrid situation is also possible by just storing the config.json in my repo and having the builder script in yours... As you want ! Or we just advertise your repo so people install it on their systems (I have a list here : #1112)

@baldarn
Copy link
Contributor Author

baldarn commented Jun 14, 2024

I think is best to drop this and use @celynw addon.

I don't have much time to follow this addon, and being that @celynw is working fine I wouldn't duplicate the efforts ;)

@baldarn baldarn closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Auto Merge PR enhancement New feature or request prevent stale Prevents stale being applied
Projects
None yet
Development

No branches or pull requests

5 participants