-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [REQUEST] Navidrome #1409
Comments
will try to take care of it |
@alexbelgium same problem with the image for |
What problem do you mean? |
mmh I'll push it |
I have a question about navidrome... |
Added the link to mount smb or local drives in /mnt |
Mmh indeed the image doesn't build but I can't understand what is wrong. Are the files formatted with lf and not crlf? |
I just changed TZ viriable and my addon doens't start after checking the logs I see:
|
Navidrome works if it is loaded standalone, it does not work if we try to load in HA's iframe (ingress). To keep it simple, if we can set |
I have to add ND_BASEURL as a variable? |
Yes, but that is still not going to make things work. See navidrome/navidrome#2605 |
i'm still unable to run this addon, any plans to update? |
hi @hiagocosta , will try to fix this next week |
Thanks! Sorry I don't have much time to look for the moment but don't hesitate if you need any support for specific elements |
trying something @alexbelgium the image is not built.. I think that could you have a look? |
Argh indeed it seems automerge doesn't work but I don't understand why... I'll have a look! If you want I'll try to look at the code tomorrow to see if I can find something :) |
Are you on HA community forum? They accept PM and we can exchange details there |
I have an addons repository with Navidrome, in case it's of any help. I did base most of it on @alexbelgium's amazing work, after all (EDIT: Why did I get a notification for a failed run caused by me simply making this comment..?) |
Hi celynw, very nice work! Glad to see that what I did can be useful to others also - the community lives on inspiring ourselves from other's work and taking it further! At my start, most of my repo was inspired by https://github.com/petersendev/hassio-addons ;-) The failed run is due to an automerge workflow that is not working ;-) long story short I wanted to find a way for "external" users to trigger a build so they could "host" their addons on my repo but still be fully autonomous in coding & building. As such, in theory the |
@celynw I was adding this addon just for fun would you like to merge yours in this collection? that would benefit the community ;) what do you think @alexbelgium ? |
For my repo, I had trouble understanding how some of the extra parts worked - The templates, bashio, S6... I also felt that I didn't need much of the CI, so I made an effort to simplify things. Although I think Navidrome itself works perfectly for me, there would be some work in making it consistent with this repository. Worth mentioning again @bilogic has a repo too! Mine is different in these ways:
I have a feeling that it would be easier to merge from @bilogic's one mentioned in #789, and maybe we could enable builds for ARM and add more documentation/config options as I did? |
Hi guys, as you want! I've put the extra parts to simplify working on several addons - I just need to change a file to update all addons ;-) The key thing is that it works... I don't necessarily want to merge as you can keep more flexibility (and personal recognition) by having your own repo, but if you want I am not against it ! An hybrid situation is also possible by just storing the config.json in my repo and having the builder script in yours... As you want ! Or we just advertise your repo so people install it on their systems (I have a list here : #1112) |
Checked
Which addon?
Navidrome
https://github.com/navidrome/navidrome/
Is your feature request related to a problem? Please describe
just want to add this
someone tried to use that, but with no luck
navidrome/navidrome#2605
Describe the solution you'd like
add the addon
The text was updated successfully, but these errors were encountered: