Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-combat relics #3

Open
alexdriedger opened this issue Jul 12, 2020 · 1 comment
Open

Remove non-combat relics #3

alexdriedger opened this issue Jul 12, 2020 · 1 comment

Comments

@alexdriedger
Copy link
Owner

Non-combat relics (eg. black star) should have no impact on damage taken in the fight. Therefore, these features should be removed. This could either be done during the run history file transformation or during data pre-processing before going into the model

@dcela
Copy link
Collaborator

dcela commented Jul 12, 2020

I feel like I would rather have a model that is evaluating which cards to pick and when. In case we end up with several different models, we should leave it in the run file and just not use it in the model later.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants