Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete github URLs #1

Open
mattrude opened this issue Jul 20, 2013 · 5 comments
Open

Incomplete github URLs #1

mattrude opened this issue Jul 20, 2013 · 5 comments

Comments

@mattrude
Copy link

After activating the plugin, the github feed URL's are not fully qualified and are leading back to the hosting site.

Example: the main feed URL is listed as /<username> instead of https://github.com/<username> (see here for a live example), this seems to be true for all URL's created by this plugin.

Looking at the code around line 130 it looks like a java script is intended to update the URL's by adding https://github.com/ to the beginning, but this script does not seem to be updating the URL as intended.

@alexkingorg
Copy link
Owner

Probably needs to enqueue jQuery if it hasn't been. Want to submit a patch?

mattrude added a commit to mattrude/wp-github-activity that referenced this issue Aug 14, 2013
@mattrude
Copy link
Author

The changes made in Pull Request #2 resolves this issue for me.

@alexkingorg
Copy link
Owner

Can we enqueue the script in cf_github_activity() (would be output in the footer) and still have it work? That way we don't enqueue jQuery on pages that don't need it.

@mattrude
Copy link
Author

Sure, ill look into it.

@mattrude
Copy link
Author

Have A look at Pull Request #2, I think it updated from my last change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants