Build fails with: conversion from Nan::Maybe<double> to v8::Maybe<double>

[benbucksch]

Environment:

• node 13.2.0
• Linux

Reproduction:

• yarn add pv-porcupine

Actual result:

• Build starts and fails with:

porcupine.cc:131:59: error: conversion from ‘Nan::imp::ValueFactoryBase<double>::return_t’ {aka ‘Nan::Maybe<double>’} to non-scalar type ‘v8::Maybe<double>’ requested
  131 |         v8::Maybe<double> sensitivityVal = Nan::To<double>(Nan::Get(keywordObject, sensitivityKeyStr).ToLocalChecked());
      |                                            ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expected result:

• Builds successfully

[benbucksch]

Fix:

Changing porcupine.cc line 131 from V8::Maybe<double> sensitivityVal = to Nan::Maybe<double> sensitivityVal = allows me to build successfully.

[gormonn]

@benbucksch Hello! How to do that?

[SteTR]

Bringing this issue back up. I changed the line but not sure how to get it functioning after that @benbucksch, what did you do afterwards?

[benbucksch]

As mentioned in my comment, this one change was all that was needed.

If your question is how to compile and use this changed source code, then I guess your easiest solution is to install my fixed version in https://github.com/benbucksch/pv-porcupine/ instead:

• npm install https://github.com/benbucksch/pv-porcupine/
• yarn add https://github.com/benbucksch/pv-porcupine/