-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Latest release breaks algoliasearch
types
#1562
Comments
Do you have a specific setup in which this reproduces? There are .d.ts files published and they're registered in the package.json too |
Something changed in the type definitions and somehow this keeps happening in this library even on minor changes which frequently breaks all of our implementations... Previously the return of With 5.9.0 this changed to
The type To me the usage of |
I just found out that there are other issues appearing after updating:
We will revert everything to the previous version for now. This should not happen on minor releases, this breaks the whole semver idea, since those changes seems to be intended and not by accident. We are all happy to migrate stuff if changes are necessary but please let us know about it. If you need any help reproducing the issue or more information feel free to reach out to me, I am happy to help! |
Hey, sorry for the issue, when adding every other existing APIs to the algolia/api-clients-automation#3988 should add the dependency back, and the I'll release 5.9.1 right away and work on a solution to better assert our |
@shortcuts no worries, things like this can happen. If you have a possibility to update your tooling to handle "wrong" typings it would be awesome since we had numerous small issues in the past. Thanks a lot for the quick fix! |
Ahaha I thought it was the case actually but seems like not really
Hopefully it's good! 5.9.1 has been released |
@shortcuts well, at least we know now that it does not work ;) Unfortunately I still have a lot of weird issues at the moment:
I am currently not sure why this is happening, I have |
Description
In
5.9.0
(migrating from5.8.1
), types are broken foralgoliasearch
.From my quick investigation, the package references types from
@algolia/client-search
, however this is not a dependency ofalgoliasearch
and causes TypeScript to returnany
. Other types that were previously accessible, likeSearchResponses
are no longer available.Client
All
Version
5.9.0
Relevant log output
No response
The text was updated successfully, but these errors were encountered: