Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type hinting for RequestOptions::setConnectTimeout(). #735

Closed
joshuapease opened this issue Aug 26, 2024 · 1 comment · Fixed by algolia/api-clients-automation#3605
Closed

type hinting for RequestOptions::setConnectTimeout(). #735

joshuapease opened this issue Aug 26, 2024 · 1 comment · Fixed by algolia/api-clients-automation#3605
Assignees
@millotp

Comments

@joshuapease
Copy link

My IDE and PHPStan are complaining about the type hinting for RequestOptions::setConnectTimeout().

I created a fork with a fix... but since these docs are auto-generated, this might not be the right way to go about fixing it.

main...joshuapease:algoliasearch-client-php:patch-1

Thanks for your great API!

Screenshots

CleanShot 2024-08-26 at 16 32 54@2x
@millotp millotp mentioned this issue Aug 28, 2024
Merged
@millotp
Copy link
Contributor

millotp commented Aug 28, 2024

Thanks for the contribution, indeed this repository is generated, I've applied your bug fix in algolia/api-clients-automation#3605, it will be fixed in the next release of the client.

Glad that you like the API !

@millotp millotp self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(php): type hint for setConnectTimeout algolia/api-clients-automation
2 participants
@joshuapease @millotp