Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_objects fails when passing in attributesToRetrieve #469

Open
PFStein opened this issue Jan 11, 2022 · 1 comment · May be fixed by #499
Open

get_objects fails when passing in attributesToRetrieve #469

PFStein opened this issue Jan 11, 2022 · 1 comment · May be fixed by #499

Comments

@PFStein
Copy link

PFStein commented Jan 11, 2022 •
edited
Loading

  • Algolia Client Version: algolia (2.2.2)
  • Language Version: ruby 2.6.5p114 (2019-10-01 revision 67812) [-darwin21]

Description

When passing in attributesToRetrieve to get_objects we receive an http error stating that attributesToRetrieve is an invalid key. We traced the issue back to the call made to the Algolia API here:

algoliasearch-client-ruby/lib/algolia/search_index.rb

Line 213 in 5e7c715

@transporter.read(:POST, '/1/indexes/*/objects', { 'requests': requests }, opts)

We tested that if we pass in request_options instead opts the call works as documented.

Steps To Reproduce

search_config = Algolia::Search::Config.new(
  application_id: 'app_id', api_key: 'api_key', symbolize_keys: false,
)
client = Algolia::Search::Client.new(search_config, { logger: Rails.logger })
index = client.init_index('my_index')
index.get_objects(['1'], { attributesToRetrieve: ["id"] })
# Fails with invalid key 'attributesToRetrieve'. Expected: appID, apiKey, requests (near 1:121)
@liamgriffiths
Copy link

Additionally, it would be nice to use opts.dup on the parameter to avoid mutating a potentially frozen options hash.

@PFStein PFStein changed the title get_objects fails when passing in attributesToRecieve get_objects fails when passing in attributesToRetrieve Jan 11, 2022
@camel2243 camel2243 linked a pull request Jul 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix get_objects fails with attributesToRetrieve camel2243/algoliasearch-client-ruby
2 participants
@liamgriffiths @PFStein