Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeConfig should return an error #49

Open
winder opened this issue Mar 31, 2023 · 0 comments
Open

makeConfig should return an error #49

winder opened this issue Mar 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@winder
Copy link
Contributor

winder commented Mar 31, 2023

Subject of the issue

When starting conduit with a data directory that has the wrong permissions, errors occur that do not halt the program.

{"__type":"Conduit","_name":"main","level":"error","msg":"Unable to create plugin data directory: mkdir data/importer_algod: permission denied","time":"2023-03-31T12:38:56Z"}

After seeing this error conduit continued to run until a later error crashes the program.

Solution

Modify makeConfig to propagate errors from MkdirAll and check them in pipeline.go:Init().

@winder winder added the bug Something isn't working label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@winder and others