Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make goal-partkey-commands e2e-subs test serial #6143

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

goal-partkey-commands.sh fails time to time when checking one vs two node dirs for part keys. There is another test that creates/removed keys so parallel execution lead so flakiness as seen here. Fixed by moving goal-partkey-commands.sh into serial sub directory.

Test Plan

Existing tests should pass.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (2a02530) to head (2c5c3b5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6143      +/-   ##
==========================================
- Coverage   56.27%   56.26%   -0.01%     
==========================================
  Files         494      494              
  Lines       69943    69943              
==========================================
- Hits        39358    39353       -5     
- Misses      27910    27913       +3     
- Partials     2675     2677       +2     
Flag Coverage Δ
56.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to include the explanation for why this is under serial, but it doesn't matter too much, I suppose.

@algorandskiy algorandskiy merged commit b782a6e into algorand:master Sep 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants