Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queries without limits returning next token #116

Open
JasonWeathersby opened this issue Jun 5, 2020 · 1 comment
Open

queries without limits returning next token #116

JasonWeathersby opened this issue Jun 5, 2020 · 1 comment
Assignees
Labels

Comments

@JasonWeathersby
Copy link

curl localhost:8980/v2/accounts/XIU7HGGAJ3QOTATPDSIIHPFVKMICXKHMOR2FJKHTVLII4FAOA3CYZQDLG4/transactions?after-time=2020-06-03T10:00:00-05:00 | json_pp

@brianolson
Copy link
Contributor

Improvement
It'd be nicer and more efficient if the server detected that it finished short of its limit (whether default or specified) and didn't send a next token when it can know that there's nothing after that next token.

In the current state, adding the next token to the query produces an empty result, which is a pretty clear sign of being done, but yeah it could be better.

@winder winder added the good first issue Good for newcomers label Feb 12, 2021
@algoanne algoanne added Team Lamprey and removed FDE labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants