Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router testing with graviton - RouterSimulation doesn't handle overloaded method names #662

Open
tzaffi opened this issue Feb 8, 2023 · 0 comments
Labels
new-feature-request Feature request that needs triage Team Scytale

Comments

@tzaffi
Copy link
Contributor

tzaffi commented Feb 8, 2023

Problem

Class tests.blackbox.RouterSimulation doesn't handle overloaded method names. In particular, consider this example; if another method in the router had the abi-signature add(uint64,uint64)void then RouterSimulation would act non-deterministically.

Solution

CallPredicates type should be keyed off method signature as opposed to current method name. This will involve refactoring a few dependencies.

Dependencies

None

Urgency

Low - for the purposes of PyTeal itself, it is easy to work around the issue by not over-loading method names. However, if there is sufficient community interest in re-using RouterSimulation for smart contract testing, then it ought to be improved in the way described.

@tzaffi tzaffi added the new-feature-request Feature request that needs triage label Feb 8, 2023
@tzaffi tzaffi mentioned this issue Feb 8, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature-request Feature request that needs triage Team Scytale
Projects
None yet
Development

No branches or pull requests

2 participants