Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uday30 #683

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Uday30 #683

wants to merge 6 commits into from

Conversation

uday7981
Copy link

@uday7981 uday7981 commented Mar 1, 2023

Hey, I have just updated the both examples:

In the first code snippet, the Algorand Node API was used to compile the smart contract TEAL code and generate a logic signature using the goal command-line tool. In the updated code, the Python SDK is used to compile the TEAL code and generate the logic signature using the algod_client.compile method. This eliminates the need to use the goal command-line tool and simplifies the code.

In the second code snippet, the logic signature was attached to a payment transaction and then sent to the Algorand network using the algod command-line tool. In the updated code, the Python SDK is used to create and send the transaction using the algod_client.send_transactions method. This simplifies the code and provides a more consistent way to interact with the Algorand network.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ uday7981
❌ udaykirannnnnn
You have signed the CLA already but the status is still pending? Let us recheck it.

@uday7981 uday7981 closed this Mar 1, 2023
@uday7981 uday7981 reopened this Mar 1, 2023
@ahangsu
Copy link
Contributor

ahangsu commented Mar 1, 2023

Hi, thanks for updating examples, and there are a few things to notice before you would like to merge in:

  1. Please consider using formatter to format your code, CI process failed for not formatting your code properly.
    A convenient way to setup environment and everything you need is going through https://github.com/algorand/pyteal#development-setup
  2. Please consider update your SDK version. From your code example it seems you are still on py-sdk v1, please use updated version v2.
  3. Is this PR duplicating with Update examples.rst #640? If so please remain only one of them.
  4. There are 2 committers (assuming both are your accounts) on your branch, then please consider let both sign CLA.

Let me know if anything I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants