Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to use-wallet v3 #270

Open
neilcampbell opened this issue Oct 7, 2024 · 0 comments
Open

Upgrade to use-wallet v3 #270

neilcampbell opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
Enhancements

Comments

@neilcampbell
Copy link
Contributor

We use some interesting tricks in lora to support network switching in use-wallet v2, so we might be able to simplify the integration. It will need to be throughly tested after upgrade though.

In v2 the KMD provider doesn't store the active KMD wallet, so when reloading it assumes unencrypted-default-wallet. If you connect a different wallet, then reload transaction signing breaks. To fix this we disconnect the KMD wallet on reload. Hopefully v3 has fixed this, so we can remove this behaviour, as it's annoying.
@neilcampbell neilcampbell added the enhancement New feature or request label Oct 7, 2024
@neilcampbell neilcampbell added this to the Enhancements milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Enhancements
Development

No branches or pull requests
1 participant
@neilcampbell