Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Cut off the string if it exceeds max_length. #4359

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Dec 12, 2024

As titled.

Fix #4365
FIx #4383

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Please check the preview of the documentation changes at
https://f810789d.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.78%. Comparing base (26b29b3) to head (69bb9ee).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4359       +/-   ##
===========================================
+ Coverage   34.33%   58.78%   +24.44%     
===========================================
  Files         126       12      -114     
  Lines       13257      592    -12665     
===========================================
- Hits         4552      348     -4204     
+ Misses       8705      244     -8461     

see 126 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936371c...69bb9ee. Read the comment docs.

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
@zhanglei1949 zhanglei1949 changed the title fix(interactive): Fix error on macos fix(interactive): Cut off the string if it exceed max_length Dec 13, 2024
@zhanglei1949 zhanglei1949 changed the title fix(interactive): Cut off the string if it exceed max_length fix(interactive): Cut off the string if it exceeds max_length. Dec 13, 2024
Committed-by: xiaolei.zl from Dev container
@zhanglei1949
Copy link
Collaborator Author

TODO: We should support VAR_CHAR on compiler first or all. @shirly121

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants