Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--pass-authorization-header标志行为和oauth2proxy主干不一致 #1501

Open
ningpengtao-coder opened this issue Nov 11, 2024 · 4 comments
Open

--pass-authorization-header标志行为和oauth2proxy主干不一致 #1501

ningpengtao-coder opened this issue Nov 11, 2024 · 4 comments
Assignees
@Jing-ze
Labels
sig/wasm type/bug Something isn't working

Comments

@ningpengtao-coder
Copy link

目前oauth2proxy--pass-authorization-header标志传递的是AccessToken，按照原oauth2proxy项目的含义应该是传递IDToken。
https://github.com/higress-group/oauth2-proxy/blob/v1.0.0/oauthproxy.go#L415
@johnlanni
Copy link
Collaborator

cc @rinfx @Jing-ze

@Jing-ze
Copy link
Contributor

Jing-ze commented Nov 11, 2024 •
edited
Loading

应该修改为：

proxywasm.AddHttpRequestHeader("Authorization", fmt.Sprintf("%s %s", providers.TokenTypeBearer, session.IDToken))

@johnlanni johnlanni added type/bug Something isn't working sig/wasm labels Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Todo in Higress Nov 11, 2024
@Jing-ze Jing-ze mentioned this issue Nov 12, 2024
Merged
4 tasks
@Jing-ze
Copy link
Contributor

Jing-ze commented Nov 12, 2024

已在oauth2proxy仓库下提交pr：
higress-group/oauth2-proxy#4

@johnlanni
Copy link
Collaborator

@Jing-ze 已经合并，可以再更新下插件的go mod依赖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jing-ze Jing-ze

Labels
sig/wasm type/bug Something isn't working
Projects
Higress
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnlanni @ningpengtao-coder @Jing-ze