Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please upgrade pmd version to latest #742

Closed
liaoguode opened this issue Aug 12, 2020 · 11 comments
Closed

please upgrade pmd version to latest #742

liaoguode opened this issue Aug 12, 2020 · 11 comments

Comments

@liaoguode
Copy link

Is your feature request related to a problem? Please describe.
please upgrade pmd version to latest

Describe the solution you'd like
the pmd latest version is 6.26.0, but p3c use 6.15.0.please upgrade pmd version to use new feature

@LuffyGao
Copy link
Contributor

@imu2008

@imu2008
Copy link
Contributor

imu2008 commented Aug 19, 2020

@liaoguode OK,we will assess the necessity for an upgrade and do it as soon as possible,tks

@XenoAmess
Copy link

XenoAmess commented Aug 19, 2020

@liaoguode
That is not as easy as click an update button...
Some rules have changed in new version of pmd.
@imu2008
Just, be careful.
If need any help I'm glad to share.

besides the update will cause a lot of functions we using now be deprecated...
It is a tough work if you wanna achieve it and not using any deprecated functions.
Hope you will succeed.

@imu2008
Copy link
Contributor

imu2008 commented Aug 19, 2020

@XenoAmess it is wonderful for you can commit a MR about this feature

@XenoAmess
Copy link

XenoAmess commented Aug 19, 2020

@imu2008 I created a pr several months ago...
well, I admit I change too many things and it is a little difficult to discover what are you needed...
#660

I remember the most confusing thing happened at 6.17 to 6.18 upgrade.
Here is the question I asked then.(and answered by pmd guys)
https://stackoverflow.com/questions/61161312/rule-failed-test-while-trying-to-upgrade-pmd-from-6-17-0-to-6-18-0

@liaoguode
Copy link
Author

@imu2008 thank you, I think this is a good idea.

@XenoAmess
Copy link

XenoAmess commented Aug 19, 2020

@liaoguode

I think this is a good idea.

yes, it is.
upgrading to 6.22 can bring new features about java 14 new grammar (for example, switch).
it is really useful for some people.

what I wanna say is, it is not easy, and will take tons of time to do so.
(and consider about in this repo they do never use any deprecated functions, and the update will bring many many deprecated functions...)

@liaoguode
Copy link
Author

@liaoguode

I think this is a good idea.

yes, it is.
upgrading to 6.22 can bring new features about java 14 new grammar (for example, switch).
it is really useful for some people.

what I wanna say is, it is not easy, and will take tons of time to do so.
(and consider about in this repo they do never use any deprecated functions, and the update will bring many many deprecated functions...)

@XenoAmess
yes ,it is.
I have find 300+ deprecated functions when I upgrade to 6.26.0, upgrade to latest version will spend a lot of time, maybe need large number of people to work it.
we will use p3c to be our static java code analysis, we will work it, want p3c is better.

@XenoAmess
Copy link

XenoAmess commented Aug 19, 2020

@liaoguode

I think this is a good idea.

yes, it is.
upgrading to 6.22 can bring new features about java 14 new grammar (for example, switch).
it is really useful for some people.
what I wanna say is, it is not easy, and will take tons of time to do so.
(and consider about in this repo they do never use any deprecated functions, and the update will bring many many deprecated functions...)

@XenoAmess
yes ,it is.
I have find 300+ deprecated functions when I upgrade to 6.26.0, upgrade to latest version will spend a lot of time, maybe need large number of people to work it.
we will use p3c to be our static java code analysis, we will work it, want p3c is better.

(sigh) In my tpm at https://github.com/XenoAmess/p3c I can only make sure it can work on 6.22.0
But for removing all deprecated functions...
Forgive me, that is toooo much work to do, I just give up.

@liaoguode
Copy link
Author

@XenoAmess I find upgrade pmd version can not fix the all deprecated functions. the 6.26.0 only have less replace function for deprecated functions. The pmd version 7.0.0 will give the most replace function, maybe upgrade to 7.0.0 is better.

@XenoAmess
Copy link

XenoAmess commented Aug 24, 2020

@liaoguode

@XenoAmess I find upgrade pmd version can not fix the all deprecated functions. the 6.26.0 only have less replace function for deprecated functions. The pmd version 7.0.0 will give the most replace function, maybe upgrade to 7.0.0 is better.

Maybe it is better to deprecate the Rule that forbid us using any deprecated functions, just like what I did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants