From e4f130f5ac4a8245214c4f17e893002a2aa5efcf Mon Sep 17 00:00:00 2001 From: Fabien Castan Date: Thu, 21 Sep 2023 08:34:36 +0200 Subject: [PATCH 1/3] [ui] viewer: default value for fps is now 24 --- meshroom/ui/qml/Viewer/SequencePlayer.qml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meshroom/ui/qml/Viewer/SequencePlayer.qml b/meshroom/ui/qml/Viewer/SequencePlayer.qml index b3be73a4b4..27d206d695 100644 --- a/meshroom/ui/qml/Viewer/SequencePlayer.qml +++ b/meshroom/ui/qml/Viewer/SequencePlayer.qml @@ -43,7 +43,7 @@ FloatingPane { property bool syncSelected: true property bool playing: false property bool repeat: false - property real fps: 1 + property real fps: 24 onFrameChanged: { updateReconstructionView(); @@ -231,6 +231,7 @@ FloatingPane { from: 1 to: 60 stepSize: 1 + value: m.fps onValueChanged: { m.fps = value; From f1c906ad4f3fcf896d1038ce397974e2ffdc3386 Mon Sep 17 00:00:00 2001 From: Fabien Castan Date: Thu, 21 Sep 2023 08:35:25 +0200 Subject: [PATCH 2/3] [ui] SequencePlayer: change "repeat" icon --- meshroom/ui/qml/Viewer/SequencePlayer.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meshroom/ui/qml/Viewer/SequencePlayer.qml b/meshroom/ui/qml/Viewer/SequencePlayer.qml index 27d206d695..a182ed7b7a 100644 --- a/meshroom/ui/qml/Viewer/SequencePlayer.qml +++ b/meshroom/ui/qml/Viewer/SequencePlayer.qml @@ -244,7 +244,7 @@ FloatingPane { checkable: true checked: false - text: MaterialIcons.replay + text: MaterialIcons.repeat ToolTip.text: "Repeat" onCheckedChanged: { From 191663f47110aba99f90704e49f75f38b1eeccc9 Mon Sep 17 00:00:00 2001 From: Fabien Castan Date: Thu, 21 Sep 2023 08:36:53 +0200 Subject: [PATCH 3/3] [ui] SequencePlayer: play on last frame restart from the beginning --- meshroom/ui/qml/Viewer/SequencePlayer.qml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meshroom/ui/qml/Viewer/SequencePlayer.qml b/meshroom/ui/qml/Viewer/SequencePlayer.qml index a182ed7b7a..a82a3cd73f 100644 --- a/meshroom/ui/qml/Viewer/SequencePlayer.qml +++ b/meshroom/ui/qml/Viewer/SequencePlayer.qml @@ -55,7 +55,11 @@ FloatingPane { onPlayingChanged: { syncSelected = !playing; - viewer.playback(m.playing); + if(playing && (frame + 1 >= sortedViewIds.length)) + { + frame = 0; + } + viewer.playback(playing); } }