Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

中间人攻击: NODE_TLS_REJECT_UNAUTHORIZED enables Man-in-the-middle Attacks (MiTM) #515

Open
WookieSheep opened this issue Oct 10, 2024 · 0 comments

Comments

@WookieSheep
Copy link

WookieSheep commented Oct 10, 2024

The following exists in https://github.com/aliyun/oss-browser/blob/develop/main.js#L6 and has been present for 3 years according to the repository history.

It appears to also be present in downloads provided by alibabacloud.com
https://www.alibabacloud.com/help/en/oss/developer-reference/install-and-log-on-to-ossbrowser

// use self signed certificate for Apsara Stack
// https://stackoverflow.com/questions/58615762/will-an-electron-based-app-pass-system-wide-nodejs-environment-variables
process.env["NODE_TLS_REJECT_UNAUTHORIZED"] = 0;

NODE_TLS_REJECT_UNAUTHORIZED should be removed here as it allows for MitM capabilities for adversaries.

A test was carried out locally to confirm:
image

Login credentials and data are likely not secure until this is fixed.

@WookieSheep WookieSheep changed the title NODE_TLS_REJECT_UNAUTHORIZED enables Man-in-the-middle Attacks (MiTM) 中间人攻击: NODE_TLS_REJECT_UNAUTHORIZED enables Man-in-the-middle Attacks (MiTM) Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant