Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: When a notification is hidden counter still counts it #7324

Open
hero101 opened this issue Dec 13, 2024 · 2 comments
Open

BUG: When a notification is hidden counter still counts it #7324

hero101 opened this issue Dec 13, 2024 · 2 comments
Labels
bug Something isn't working client

Comments

@hero101
Copy link
Collaborator

hero101 commented Dec 13, 2024

Describe the bug
When broken notifications (with missing resources) are fetched but not displayed to the user, the unread counter counts them even if they are not displayed. That leads to a negative behavior where 1 notification is displayed but the counter consistently shows more and the user is unable to react in any way.

To Reproduce
Steps to reproduce the behavior:

  1. Publish a callout
  2. Notification is received automatically
  3. Delete the callout
  4. The notification is not displayed but still counted as unread

Expected behavior
Notifications that are not displayed must not be counted as unread.

Screenshots
image.png

Areas that will be affected

@hero101 hero101 added bug Something isn't working client labels Dec 13, 2024
@hero101
Copy link
Collaborator Author

hero101 commented Dec 13, 2024

I am starting to believe that the server must know about how and when each notification type can break and filter it out / delete it.
Many more potential issues will arise with the new additions

@bobbykolev bobbykolev self-assigned this Dec 16, 2024
@bobbykolev
Copy link
Contributor

bobbykolev commented Dec 16, 2024

Agreed!

Currently, the client handles broken notifications in the notification's view component by excluding them from the render.
The badge is controlled by the initial count of unseen notifications. Conceptually the client shouldn't apply additional logic. As Svetlio suggested, it's better to be filtered on the server.

@bobbykolev bobbykolev removed their assignment Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client
Projects
None yet
Development

No branches or pull requests

2 participants