Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attrs version #102

Open
mmiller-max opened this issue Mar 3, 2022 · 3 comments · May be fixed by #121
Open

attrs version #102

mmiller-max opened this issue Mar 3, 2022 · 3 comments · May be fixed by #121

Comments

@mmiller-max
Copy link
Contributor

Hi there,

Is there any reason for this upperbound?

attrs>=18.0,<20.4.0

Looking at the release log I don't think clearml-agent will be affected by any of the breaking changes, but I'm not an expert!

If it can be upgraded to attrs>=18.0,<21.5.0 I'll make a PR.

@jkhenning
Copy link
Member

Well, there were a few breaking changes that caused us to limit the version (IIRC it was related to the cmp argument). I have no objection to such a PR, but it will require in-depth testing to make sure nothing was broken, and I would appreciate a summary of all (potentially) breaking changes in attrs versions (>20.3.0) for features used in our code 🙂

@Honzys
Copy link
Contributor

Honzys commented Oct 19, 2022

Well, there were a few breaking changes that caused us to limit the version (IIRC it was related to the cmp argument). I have no objection to such a PR, but it will require in-depth testing to make sure nothing was broken, and I would appreciate a summary of all (potentially) breaking changes in attrs versions (>20.3.0) for features used in our code slightly_smiling_face

Hello @jkhenning ,
Can I kindly ask you what is the status on this issue?

We would also really appreciate freeing up the upper version limit for attrs.

AFAIK it should not break any other functionality except the cmp property, which could be just fixed using the .eq and .order.
You can see this here - https://github.com/python-attrs/attrs/pull/939/files

List of breaking changes can be seen here - https://www.attrs.org/en/stable/changelog.html#id36
Version 21.1.0 have been yanked from the PyPI, so there's only 4 new versions that we need to thoroughly check.

And if I am not mistaken, there's no other changes to the attr module, they've only made changes to the attrs module.

So what do you think? Could we create a PR to release the upper limit?

@jkhenning
Copy link
Member

Hi @Honzys,

Sure, we would welcome a PR 🙂 👍

@Honzys Honzys linked a pull request Oct 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants