Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export_umls_json.py failing #509

Closed
ethanhkim opened this issue Mar 13, 2024 · 4 comments
Closed

export_umls_json.py failing #509

ethanhkim opened this issue Mar 13, 2024 · 4 comments

Comments

@ethanhkim
Copy link
Contributor

Hi! I noticed that while I was trying to build my own Linker, the script export_umls_json.py is currently failing, and may have been for the past 10 months. Traceback below:

  Traceback (most recent call last):
    File "/dir/to/project/export_umls_json.py", line 115, in <module>
      main(args.meta_path, args.output_path, args.lang, args.source, args.non_suppressed)
  TypeError: main() takes from 2 to 4 positional arguments but 5 were given

Commenting out the last argument (lines 109-113) doesn't resolve the issue as well, creating an empty jsonl file.

For now, I'm using the previous commit's code but the current script may need to be reverted. Thanks!

@dakinggg
Copy link
Collaborator

Ah looks like a mistake in the last pr that touched that file! Would you be interested in opening a PR to fix it?

@ethanhkim
Copy link
Contributor Author

For sure, I'll look into fixing it! Should also be useful for anyone following up #237 .

@ethanhkim
Copy link
Contributor Author

ethanhkim commented Mar 19, 2024

@dakinggg, PR's open for review: #511.

@dakinggg
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants