Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI scanning progress bar #11

Open
SmiVan opened this issue Nov 9, 2023 · 1 comment
Open

UI scanning progress bar #11

SmiVan opened this issue Nov 9, 2023 · 1 comment

Comments

@SmiVan
Copy link

SmiVan commented Nov 9, 2023

For your consideration: When scanning large memory spaces, it would be convenient to have a progress bar so the user can see that the application is not stuck and can get the general idea of how long they have to wait for.

I've made a basic example implementation of this at SmiVan/med:progressbar, but I'm a Qt beginner and don't practice C++ very often, so its probably a bit too primitive/messy for a pull request.

Example implementation of progress bar

That being said, I think that the general idea of incrementing a mutex-guarded counter at the end of each map-scanning thread is sufficient to provide a decent progress bar without affecting the scanning speed too much.

@allencch
Copy link
Owner

Hi @SmiVan , thank you for this great feature. I just created a staging branch (https://github.com/allencch/med/tree/staging). Do you mind to create a pull request and target to staging branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants