Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecation error in WPCS until 3.0 is ready to be used #34

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Aug 29, 2023

Use a fix from WordPress/WordPress-Coding-Standards#2035 (comment) to allow the coding standards to be used against PHP 8.0+ without requiring any extra Composer repository.

It looks as if https://github.com/Automattic/VIP-Coding-Standards preparing to release a new version soon that will require WPCS 3.0 given the latest changes in their develop branch. In the meantime, we can allow our projects to use the Alley Coding Standards against PHP 8.0+ without needing a Composer workaround. Upgrading to PHP 8.1 will be as simple as composer update to make PHPCS happy.

@srtfisher srtfisher requested a review from a team as a code owner August 29, 2023 20:15
Copy link

@jessicamgoddard jessicamgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srtfisher srtfisher merged commit 7b449f3 into develop Aug 29, 2023
@srtfisher srtfisher deleted the wpcs-3-0 branch August 29, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants