From 8f8983dfa619c171d36d1ddc6d0fa84f163966f8 Mon Sep 17 00:00:00 2001 From: David Herrera Date: Fri, 15 Nov 2024 01:29:04 -0500 Subject: [PATCH 1/2] Enable caption on the Cover component by default --- assets/themes/classic.json | 1 + assets/themes/colorful.json | 1 + assets/themes/dark.json | 1 + assets/themes/default.json | 1 + assets/themes/modern.json | 1 + assets/themes/pastel.json | 1 + 6 files changed, 6 insertions(+) diff --git a/assets/themes/classic.json b/assets/themes/classic.json index 29ea13b6..052ce6a1 100644 --- a/assets/themes/classic.json +++ b/assets/themes/classic.json @@ -44,6 +44,7 @@ "caption_line_height": 19, "caption_size": 14, "caption_tracking": -1, + "cover_caption": true, "cite_color": "#333333", "cite_font": "Helvetica-Bold", "cite_line_height": 19, diff --git a/assets/themes/colorful.json b/assets/themes/colorful.json index eacb84e9..d4d5feb6 100644 --- a/assets/themes/colorful.json +++ b/assets/themes/colorful.json @@ -44,6 +44,7 @@ "caption_line_height": 22, "caption_size": 14, "caption_tracking": -3, + "cover_caption": true, "cite_color": "#3045ca", "cite_font": "Georgia", "cite_line_height": 22, diff --git a/assets/themes/dark.json b/assets/themes/dark.json index 3e7ac239..a0ca5dc9 100644 --- a/assets/themes/dark.json +++ b/assets/themes/dark.json @@ -44,6 +44,7 @@ "caption_line_height": 19, "caption_size": 14, "caption_tracking": -1, + "cover_caption": true, "cite_color": "#999999", "cite_font": "Helvetica-Light", "cite_line_height": 19, diff --git a/assets/themes/default.json b/assets/themes/default.json index 11319f70..e155a6f0 100644 --- a/assets/themes/default.json +++ b/assets/themes/default.json @@ -44,6 +44,7 @@ "caption_line_height": 24, "caption_size": 16, "caption_tracking": 0, + "cover_caption": true, "cite_color": "#4f4f4f", "cite_font": "AvenirNext-Italic", "cite_line_height": 24, diff --git a/assets/themes/modern.json b/assets/themes/modern.json index 133ce0ba..cb57629c 100644 --- a/assets/themes/modern.json +++ b/assets/themes/modern.json @@ -44,6 +44,7 @@ "caption_line_height": 17, "caption_size": 14, "caption_tracking": 0, + "cover_caption": true, "cite_color": "#000000", "cite_font": "AvenirNext-DemiBold", "cite_line_height": 17, diff --git a/assets/themes/pastel.json b/assets/themes/pastel.json index 2ce65b3e..a7d1c60d 100644 --- a/assets/themes/pastel.json +++ b/assets/themes/pastel.json @@ -44,6 +44,7 @@ "caption_line_height": 19, "caption_size": 14, "caption_tracking": -1, + "cover_caption": true, "cite_color": "#333333", "cite_font": "AvenirNext-Regular", "cite_line_height": 19, From 69ffe3683892ba8536d045f7592608fe3f2c763a Mon Sep 17 00:00:00 2001 From: David Herrera Date: Fri, 15 Nov 2024 23:56:02 -0500 Subject: [PATCH 2/2] Update global setting default --- includes/apple-exporter/class-theme.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/apple-exporter/class-theme.php b/includes/apple-exporter/class-theme.php index b6625012..abf4befd 100644 --- a/includes/apple-exporter/class-theme.php +++ b/includes/apple-exporter/class-theme.php @@ -886,7 +886,7 @@ private static function initialize_options() { 'type' => 'integer', ], 'cover_caption' => [ - 'default' => false, + 'default' => true, 'label' => __( 'Enable caption on the Cover component', 'apple-news' ), 'type' => 'boolean', ],