Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts_per_page may not be working properly #18

Open
bcampeau opened this issue Nov 11, 2015 · 1 comment
Open

Posts_per_page may not be working properly #18

bcampeau opened this issue Nov 11, 2015 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bcampeau
Copy link
Member

It seems that when using ES, $wp_query->query_vars['posts_per_page'](inc/post-types/class-post-type-slideshow.php line 142) isn't returning the correct posts_per_page used. It's instead using the site default of 10 (get_option( 'posts_per_page' ));

This is happening at es-wp-query/class-es-wp-query-shoehorn.php in reboot_query_vars() (line 219 currently).

Manually setting $query->query['posts_per_page'] will stop es-wp-query from overwriting the posts_per_page, and this should hopefully be a usable fix until we can look more into why the plugin isn't using the correct number.

@bcampeau bcampeau added the bug Something isn't working label Nov 11, 2015
@mboynes mboynes modified the milestone: 1.0 Feb 29, 2016
@sboisvert
Copy link
Contributor

@bcampeau could this be related to #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants