Issue-187: Page size is displayed incorrectly #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue described in Page size is displayed incorrectly. It corrects the page size display when running the command with a page size of 1000 or above.
Fixes #187
Description
When the page size is set to 1000 or above, the message displayed in the CLI is incorrect. This fix ensures that the correct page size is displayed, improving the accuracy of the feedback provided to the user. The update involves a change to expect a string for the page size, ensuring that larger numbers are handled correctly.
How to Test
wp searchpress index --flush --put-mappingwith a page size of 1000 or higher.Additional Information
No additional information provided.