Issue-182: Trim down @wordpress dependencies to those only used in code #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboynes
approved these changes
Dec 31, 2024
blocks/email-settings/edit.tsx
Outdated
| @@ -92,6 +92,7 @@ export default function Edit() { | |||
| newBlocks = [...parsedContentFromTemplate]; | |||
| } | |||
|
|
|||
| // @ts-ignore | |||
There was a problem hiding this comment.
comment applies throughout: it's better to use @ts-expect-error, so if somehow this line ever stops throwing an error, we'll know about it and can remove the directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #182
Fixes #183
This Pull Request addresses the issue titled "Trim down @WordPress dependencies to those only used in code" by removing and upgrading the NPM
@wordpressrelated dependencies as needed. This ensures that only the dependencies that are actively used in the codebase are included, streamlining the development process and minimizing unnecessary bloat.Use Case
Ensures that when a developer runs
npm install, only the@wordpressdependencies that are used in code are installed. This change not only removes unused dependencies but also upgrades existing ones to their latest versions, enhancing the application's security and performance.Changes
@wordpressdependencies frompackage.json.@wordpressdependencies to their latest.Test Instructions
npm install.@wordpressdependencies are installed and that the application builds correctly. Also, ensure that the upgraded dependencies do not introduce any breaking changes.Additional Information
For more details, see the original issue here: #182