Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z7_STRING handling in the function cells_for_geo_points #11

Open
tik65536 opened this issue Dec 22, 2024 · 0 comments
Open

Z7_STRING handling in the function cells_for_geo_points #11

tik65536 opened this issue Dec 22, 2024 · 0 comments

Comments

@tik65536
Copy link
Contributor

The function cells_for_geo_points needs to be adjusted to handle Z7_STRING from line 1415 onward.

   if cell_ids_only == True:
       # The column name should align with output_address_type 
       geodf_points_wgs84['seqnums'] = cell_id_list
       return geodf_points_wgs84
   else:
       # grid_gen from seqnums
       #  Here need to add the input_address_type and output_address_type to align with what is pass in
       gdf = self.grid_cell_polygons_from_cellids(cell_id_list=cell_id_list,
                                                    dggs_type=dggs_type,
                                                    resolution=resolution,
                                                    mixed_aperture_level=mixed_aperture_level)

Tik

tik65536 added a commit to LandscapeGeoinformatics/dggrid4py that referenced this issue Dec 23, 2024
    - change output file name of output_conf
      prefix with {output_address_type}
    - supply dtype to pd.read_csv if output_address_type
      contains "STRING" (otherwise it will auto convert to int64)
    - change the cells_id column to "name" in the return df.
      Align with other's functions.
    - update parameters when calling grid_cell_polygons_from_cellids
      with
       a. input_address_type=output_address_type
       b. output_address_type=output_address_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant