Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] embed consensus transaction types in eth_getTransaction #1165

Open
mattsse opened this issue Aug 21, 2024 · 0 comments · May be fixed by #1169
Open

[Feature] embed consensus transaction types in eth_getTransaction #1165

mattsse opened this issue Aug 21, 2024 · 0 comments · May be fixed by #1169
Assignees
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Aug 21, 2024

Component

rpc

Describe the feature you would like

according to the spec https://ethereum.github.io/execution-apis/api-documentation/

eth_getTransaction returns the full transaction object

image

so we should be able to fully embed the consensus tx objects in the response object, like TxEnvelope

This likely requires manual serde, we could use the existing rpc::Transaction as the initial deserialize target and then do the conversion in deserialize internally, this is most likely the easiest solution because it should be more efficient than untagged.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants