chore: change requests to flat encoding #1378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse,
prestwich and
emhane
as code owners
|
Please do not merge this upon approval, I'd like to merge the devnet 4 PRs in one go when necessary. |
|
Putting this back in draft since the encoding changed yet again (and pretty significantly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In devnet 4, the current request encoding scheme is replaced with a flat encoding scheme, i.e. no rlp involved.
The request payloads (i.e. bytes following the request type byte) are now encoded as follows:
source_address ++ source_pubkey ++ target_pubkeysource_address ++ validator_pubkey ++ amountpubkey ++ withdrawal_credentials ++ amount ++ signature ++ indexSolution
I decided to simply implement
Encodable7685andDecodable7685for each request type, and for theRequestenum wrapper inalloy-consensus, I defer to these implementations.Closes #1338
PR Checklist