Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Replace assert_eq! with similar_asserts::assert_eq! #1362

Closed
yash-atreya opened this issue Sep 25, 2024 · 2 comments · Fixed by #1429
Closed

[Feature] Replace assert_eq! with similar_asserts::assert_eq! #1362

yash-atreya opened this issue Sep 25, 2024 · 2 comments · Fixed by #1429
Assignees
@0xriazaka
Labels
debt Tech debt which needs to be addressed enhancement New feature or request good first issue Good for newcomers

Comments

@yash-atreya
Copy link
Member

yash-atreya commented Sep 25, 2024 •
edited
Loading

Component

other

Describe the feature you would like

similar_asserts::assert_eq! highlights the exact differences between test subjects. This is incredibly helpful while debugging tests OR when we have to change test suites due to a breaking change e.g. #1358

Additional context

No response
@yash-atreya yash-atreya added enhancement New feature or request debt Tech debt which needs to be addressed good first issue Good for newcomers labels Sep 25, 2024
@0xriazaka
Copy link
Contributor

can i work this?

@yash-atreya
Copy link
Member Author

@0xriazaka assigned!

This was referenced Oct 3, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xriazaka 0xriazaka

Labels
debt Tech debt which needs to be addressed enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@yash-atreya @0xriazaka