-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New and improved library and macro API #14
Comments
Hi can I take on this ? |
Before assigning this, can you unpack a little more about how you're planning to approach this? Dani wrote a great initial spec above, worth splitting this into sub-tracking issues and sub-tasks that you may own and we can split with others. |
A. Trait and Struct Implementations B. Macro Attributes and Derive Macros |
@gakonst @DaniPopes ; is there any adjustments to be noted before taken on this ? |
Library API
Other, not pictured:
dyn Encodable
, enabling use of a genericEncoder
.Improvements:
rlp
to avoid conflicts on common types#[rlp(flatten)]
, see belowDerive macros
New attributes:
#[rlp(flatten)]
: encode and decode usingraw
#[rlp(tagged)]
: impls for enumstagged
: defaults to the variant's discriminant value, or the variant can have an#[rlp(tag = <expr>)]
attribute.P2PMessage
#[rlp(transparent)]
: replaces the separate*Wrapper
macros#[rlp(skip)]
in field number calculationThe text was updated successfully, but these errors were encountered: