Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Package does not export typing information #121

Open
cygnuson opened this issue Nov 27, 2023 · 0 comments
Open

Package does not export typing information #121

cygnuson opened this issue Nov 27, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cygnuson
Copy link

cygnuson commented Nov 27, 2023

Description
Package.json does not export typing information:

Screenshot from 2023-11-27 09-08-11

"exports": { "import": "./dist/mjs/index.js", "require": "./dist/cjs/index.cjs", "default": "./dist/alpaca.browser.min.js" },

Expected
Package.json should export typing information

"exports": { "import": "./dist/mjs/index.js", "require": "./dist/cjs/index.cjs", "default": "./dist/alpaca.browser.min.js", "types": "./@types/index.d.ts" },

Reproduction

  1. Start a react/typescript project with latest vite npm create vite@latest
  2. install this package npm i @master-chief/alpaca
  3. Load project in vs-code
  4. import items import { AlpacaClient, AlpacaStream } from "@master-chief/alpaca"
  5. see error with vscode

Additional
Not a huge deal but requires modification of the package in node_modules in order to produce IDE hinting

making this modification in the node_modeules package (shown in expected section) fixes the issue

@cygnuson cygnuson added the bug Something isn't working label Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants