From 6f86d191244d9c44e6eb62fe3b3eb4894e3d7b73 Mon Sep 17 00:00:00 2001
From: dakimura <34202807+dakimura@users.noreply.github.com>
Date: Sat, 11 Sep 2021 18:11:29 +0900
Subject: [PATCH] refactor: use sync.Map for directMap (#500)

---
 catalog/catalog.go | 37 +++++++++++++++++++++++--------------
 1 file changed, 23 insertions(+), 14 deletions(-)

diff --git a/catalog/catalog.go b/catalog/catalog.go
index f8ebb5fc..af2dba5f 100644
--- a/catalog/catalog.go
+++ b/catalog/catalog.go
@@ -23,7 +23,7 @@ type Directory struct {
 	category       string
 
 	// directMap[Key]: Key is the directory path, including the rootPath and excluding filename
-	directMap map[string]*Directory
+	directMap *sync.Map
 	// subDirs[Key]: Key is the name of the directory, aka "ItemName" which is an instance of the category
 	subDirs map[string]*Directory
 
@@ -38,17 +38,16 @@ type Directory struct {
 func NewDirectory(rootPath string) (*Directory, error) {
 	d := &Directory{
 		// Directmap will point to each directory node using a composite key
-		directMap: make(map[string]*Directory),
+		directMap: &sync.Map{},
 	}
 
 	// Load is single thread compatible - no concurrent access is anticipated
-	rootDmap := d.directMap
-	err := load(rootDmap, d, rootPath, rootPath)
+	err := load(d.directMap, d, rootPath, rootPath)
 
 	return d, err
 }
 
-func load(rootDmap map[string]*Directory, d *Directory, subPath, rootPath string) error {
+func load(rootDmap *sync.Map, d *Directory, subPath, rootPath string) error {
 	relPath, _ := filepath.Rel(rootPath, subPath)
 	d.itemName = filepath.Base(relPath)
 	d.pathToItemName = filepath.Clean(subPath)
@@ -80,7 +79,7 @@ func load(rootDmap map[string]*Directory, d *Directory, subPath, rootPath string
 				return fmt.Errorf(io.GetCallerFileContext(0) + ", " + err.Error())
 			}
 		} else if filepath.Ext(leafPath) == ".bin" {
-			rootDmap[d.pathToItemName] = d
+			rootDmap.Store(d.pathToItemName, d)
 			if d.datafile == nil {
 				d.datafile = make(map[string]*io.TimeBucketInfo)
 			}
@@ -392,8 +391,10 @@ func (d *Directory) GetSubDirectoryAndAddFile(fullFilePath string, year int16) (
 	d.Lock()
 	defer d.Unlock()
 	dirPath := path.Dir(fullFilePath)
-	if dir, ok := d.directMap[dirPath]; ok {
-		return dir.AddFile(year)
+	if d.directMap != nil {
+		if dir, ok := d.directMap.Load(dirPath); ok {
+			return dir.(*Directory).AddFile(year)
+		}
 	}
 	return nil, fmt.Errorf("Directory path %s not found in catalog", fullFilePath)
 }
@@ -403,8 +404,10 @@ func (d *Directory) GetOwningSubDirectory(fullFilePath string) (subDir *Director
 	dirPath := path.Dir(fullFilePath)
 	d.RLock()
 	defer d.RUnlock()
-	if dir, ok := d.directMap[dirPath]; ok {
-		return dir, nil
+	if d.directMap != nil {
+		if dir, ok := d.directMap.Load(dirPath); ok {
+			return dir.(*Directory), nil
+		}
 	}
 	return nil, fmt.Errorf("Directory path %s not found in catalog", fullFilePath)
 }
@@ -631,18 +634,21 @@ func (d *Directory) addSubdir(subDir *Directory, subDirItemName string) {
 		d.subDirs = make(map[string]*Directory)
 	}
 	d.subDirs[subDirItemName] = subDir
-	for key, val := range subDir.directMap {
-		d.directMap[key] = val
+	if subDir.directMap != nil {
+		subDir.directMap.Range(func(key interface{}, val interface{}) bool {
+			d.directMap.Store(key, val)
+			return true
+		})
 	}
 	subDir.directMap = nil
 }
-func (d *Directory) removeSubDir(subDirItemName string, directMap map[string]*Directory) {
+func (d *Directory) removeSubDir(subDirItemName string, directMap *sync.Map) {
 	d.Lock()
 	defer d.Unlock()
 	if _, ok := d.subDirs[subDirItemName]; ok {
 		// Note that this is a NoOp for all but the leaf node of the tree, but it's a harmless NoOp
 		subdir := d.subDirs[subDirItemName]
-		delete(directMap, subdir.pathToItemName)
+		directMap.Delete(subdir.pathToItemName)
 	}
 	delete(d.subDirs, subDirItemName)
 	if len(d.subDirs) == 0 {
@@ -666,6 +672,9 @@ func (d *Directory) recurse(elem interface{}, levelFunc levelFunc) {
 }
 
 func removeDirFiles(td *Directory) {
+	td.Lock()
+	defer td.Unlock()
+
 	os.RemoveAll(td.pathToItemName)
 }