Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change API from parameter list to parameter dict #35

Open
SimeonEhrig opened this issue Aug 30, 2023 · 0 comments
Open

change API from parameter list to parameter dict #35

SimeonEhrig opened this issue Aug 30, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@SimeonEhrig
Copy link
Member

During my work on the unit tests, I found out that the unit test framework execute tests in parallel via multithreading. This is problematic, because the generator is not thread safe, because it use the global variable param_map to map a parameter name to an index. There is no easy way to disable multithreading. So the problem cannot be solved easily. In the meantime, I found out, that the allpairspy pairwise library supports OrderedDict. If I replace the list input with a OrderedDict, the param_map variable becomes obsolete and the generator is thread safe. Also API and functions becomes much easier.

The disadvantage of the approach is a lot of work and an API break. So this issue moves the library to version 2.

@SimeonEhrig SimeonEhrig added bug Something isn't working enhancement New feature or request labels Aug 30, 2023
@SimeonEhrig SimeonEhrig added this to the Version 2.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant