Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To run the kernel: some examples use exec method, others use createTaskKernel<Acc> +enqueue. #2221

Open
mehmetyusufoglu opened this issue Jan 15, 2024 · 3 comments
Assignees

Comments

@mehmetyusufoglu
Copy link
Contributor

There are 2 ways of running a kernel. Some of the examples use alpaka::exec<Acc>(queue, workdiv...) some others use createTaskKernel<Acc> and enqueue functions.

Should all the examples use the same approach?

@psychocoderHPC
Copy link
Member

psychocoderHPC commented Jan 15, 2024

copied from: #2219 (comment)

I am wondering if it makes more sense to remove alpaka::exec<Acc>() and provide alpaka::enqueue<Acc>(queue, workdiv, kernel) or alpaka::enqueue(alpaka::TagGpuCudaRt, queue, workdiv, kernel)?
I do not see a real reason why we have two different names to enqueue a kernel. That we have different function signatures makes IMO sense.

@fwyzard
Copy link
Contributor

fwyzard commented Jan 15, 2024

@psychocoderHPC the CMS code is using alpaka::exec() because it's shorter, and people normally don't have any reason to use the other alpaka::enqueue() variants.

@psychocoderHPC
Copy link
Member

offline discussed in the dev meeting: We will keep both methods. alpaka:exec() is heavily used by CERN and will for compatibility reasons stay.
@fwyzard also mentioned that we need to take care that enqueue can enqueue generic tasks, this could be device kernels but also nonparallel host tasks.

I also said that I will provide an enqueue() interface similar to alpaka::exec() but after looking into a fix for #2222 I am not sure about the possible additional interface for enqueue.
I try to fix first #2222 and then will revisit this issue.

@psychocoderHPC psychocoderHPC self-assigned this Jan 16, 2024
@psychocoderHPC psychocoderHPC added this to the 1.2.0 milestone Jan 29, 2024
@psychocoderHPC psychocoderHPC removed this from the 1.2.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants