Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin says contact successfully saved when it did not complete fully successfully #262

Open
mcgoooo opened this issue Mar 6, 2017 · 0 comments

Comments

@mcgoooo
Copy link
Contributor

mcgoooo commented Mar 6, 2017

while developing, i came across this, a rollback (i.e. unsuccessful save can happen on the publishing api) and the contacts-admin will still report a successful save, i believe this to be incorrect.

output and error can be seen here from the publishing api
https://gist.github.com/mcgoooo/67848a4ffc6b311c4f8f912d6e3b30a2#file-gistfile1-sh-L153

which gave the output in contacts-admin of this
screen shot 2017-03-06 at 16 53 55

i believe this should show an appropriate error message.

@mcgoooo mcgoooo changed the title admin says contact successfully saved when it did not complete fully successfulyy admin says contact successfully saved when it did not complete fully successfully Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant