Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate file upload button for screen reader users #4413

Open
2 tasks
Tracked by #4242
selfthinker opened this issue Jan 8, 2025 · 1 comment
Open
2 tasks
Tracked by #4242

Fix duplicate file upload button for screen reader users #4413

selfthinker opened this issue Jan 8, 2025 · 1 comment
Assignees

Comments

@selfthinker
Copy link
Contributor

selfthinker commented Jan 8, 2025

What

The prototype is done in a way that utilises the original file upload input but hides it and adds a new button (and more).
Because the original input is only visually hidden (and from keyboard users) but is not hidden from screen reader users, they will experience two different buttons doing the same thing.

This needs to be investigated how/if the input can be hidden while still using it.

Why

A duplicate button would be confusing to screen reader users.

Who needs to work on this

Frontend developer

Who needs to review this

Accessibility specialist

Done when

  • Investigation done into how and if it's possible to have everyone only deal with a single input
  • Decision made and logged either how to implement it or what else to do in case it's not possible
@selfthinker selfthinker changed the title Screen reader and keyboard only users experience two versions of the button, decide and document result [Anika to create issue] Fix duplicate file upload button for screen reader users Jan 8, 2025
@selfthinker selfthinker moved this to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Jan 8, 2025
@selfthinker
Copy link
Contributor Author

@owenatgov mentioned in a comment that he fixed it: alphagov/govuk-frontend#5309 (comment)

But the issue is still there. I don't know if maybe it was working but something has changed? Or maybe it was only partially working? (Unfortunately I don't remember anything about that from nearly 3 months ago. But it looks like I was satisfied with it at the time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress 📝
Development

No branches or pull requests

2 participants