Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments for ignoring linting/TypeScript errors #4427

Closed
2 tasks
Tracked by #4242
romaricpascal opened this issue Jan 10, 2025 · 0 comments
Closed
2 tasks
Tracked by #4242

Remove comments for ignoring linting/TypeScript errors #4427

romaricpascal opened this issue Jan 10, 2025 · 0 comments

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Jan 10, 2025 •
edited
Loading

What

Remove comments ignoring ESLint rules or TypeScript errors, fixing the issues they were covering.

Why

Spike code was using these comments as a way to not be slowed down by linting/TypeScript. Production code should follow our linting practices and have the code type-checked.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • The code no longer contains comments disabling ESLint rules or TypeScript errors
  • The code has no linting or type errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Status: Done 🏁
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romaricpascal @kellylee-gds