Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on HEAD requests to check links #64

Open
thomasleese opened this issue Apr 13, 2017 · 1 comment
Open

Don't rely on HEAD requests to check links #64

thomasleese opened this issue Apr 13, 2017 · 1 comment

Comments

@thomasleese
Copy link
Contributor

It turns out that some servers don't fully support the HEAD method, and instead of returning the same status code as they would for get, they return something different like 404 or 500.

We cannot, therefore, rely on the HEAD request to give us useful information about the link and instead make a GET request. This does pose the problem of downloading unnecessarily large files, so some investigation needs to be made into whether it's possible to fake a HEAD request by terminating the connection as the content starts to come through.

@thomasleese
Copy link
Contributor Author

The majority of the fix has been implemented in #65 but it's still worth finding a way of avoiding downloading large files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant