Branched todos section may appear multiple times when reloading too quickly

[ghost]

Hello,

When reloading the buffer while the main TODOs list has not been populated yet, the branched section will appear multiple times.

To reproduce on this repo, branch out of master, add a todo anywhere in the code, run magit-status then hold G for a couple of seconds.

This is what happens :

I have not yet been able to identify why this happens, maybe it is a known issue.

[alphapapa]

Hi Matthias,

Thanks for reporting this. I've seen it occasionally myself.

It appears to simply be a matter of my not implementing a check for multiple such scans happening in this code:

magit-todos/magit-todos.el

Line 755 in 7724259

(when (or (eq magit-todos-branch-list t)

Whereas the main scanners have such a check:

magit-todos/magit-todos.el

Lines 725 to 732 in 7724259

	(when magit-todos-active-scan
	;; Avoid running multiple scans for a single magit-status buffer.
	(let ((buffer (process-buffer magit-todos-active-scan)))
	(when (process-live-p magit-todos-active-scan)
	(delete-process magit-todos-active-scan))
	(when (buffer-live-p buffer)
	(kill-buffer buffer)))
	(setq magit-todos-active-scan nil))

[ghost]

Should the check be implemented in magit-todos--insert-todos or in the macro defined function?

[alphapapa]

Probably here:

magit-todos/magit-todos.el

Line 755 in 7724259

(when (or (eq magit-todos-branch-list t)