New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loose Coupling Data Slice Generator #94

Closed

jeff-hernandez opened this issue Jan 3, 2020 · 1 comment

Labels

Collaborator

jeff-hernandez commented Jan 3, 2020

Do we want the data slice generator loosely coupled to the label maker?
- By loose coupling, I think the label maker can integrate better with data slices of other data frame types. This is related to Distributed Labeling Function #93.
- Currently, the logic in the data slice generator is specific to pandas dataframes. As a pandas extension, the generator can have broader applications and be easily accessible from any pandas data frame.
```
slices = df.slices('8h', start='2020-01-01', step='4h')

for ds in slices:
    ...
```

jeff-hernandez added enhancements discussion labels

Collaborator Author

jeff-hernandez commented Oct 21, 2020

This was done in #150.

jeff-hernandez closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment