Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility of now with experimental.dynamicIO in Next.js canary versions #1464

Open
3 tasks done
typeofweb opened this issue Oct 24, 2024 · 4 comments · May be fixed by #1412
Open
3 tasks done

Compatibility of now with experimental.dynamicIO in Next.js canary versions #1464

typeofweb opened this issue Oct 24, 2024 · 4 comments · May be fixed by #1412
Labels
bug Something isn't working has-workaround

Comments

@typeofweb
Copy link

Description

When dynamicIO is enabled, functions such as getMessages or getLocale cause next build to fail with the following error:

Error: Route "/_not-found" used new Date() instead of using performance or without explicitly calling await connection() beforehand. See more info here: https://nextjs.org/docs/messages/next-prerender-current-time

Verifications

Mandatory reproduction URL

https://github.com/typeofweb/repro-nextintl

Reproduction description

Steps to reproduce:

  1. Run pnpm build.
  2. Observe the error.
  3. Remove usage of getMessages from layout.tsx.
  4. Run pnpm build.
  5. Observe no errors.

Expected behaviour

No errors.

@typeofweb typeofweb added bug Something isn't working unconfirmed Needs triage. labels Oct 24, 2024
@amannn
Copy link
Owner

amannn commented Oct 25, 2024

That's interesting, thanks for the report!

The reason is that next-intl constructs a now value when the first component calls into i18n/request.ts (in your case through getMessages). This is in turn used for relative time formatting.

However, in your case (and probably many other apps), there's no need for relative time formatting.

Some potential solutions that come to my mind:

  1. Construct the date only when format.relativeTime(…) is called
  2. Remove a default for now generally, let the user provide this
  3. Make now mandatory for format.relativeTime(…) and remove this from i18n/request.ts

It seems like these approaches all have some drawbacks, e.g. not being able to forward now to the client side, requiring a bit more work for the user, etc.

This needs a bit further investigation. It's also still very early for PPR and dynamicIO, will have to see how the feature moves along. However, from the current perspective it seems like next-intl will have to adjust in some way.

Workaround

As a stopgap solution, you can put a 'use cache' at relevant places.

E.g. in i18n/request.ts:

import {getRequestConfig} from 'next-intl/server';

async function now() {
  'use cache';
  return new Date();
}

export default getRequestConfig(async () => ({
  locale: 'en-US',
  messages: {},
  now: await now()
}));

… or in entry points (like layout.tsx).

@amannn amannn added has-workaround and removed unconfirmed Needs triage. labels Oct 25, 2024
@amannn
Copy link
Owner

amannn commented Oct 28, 2024

I just noticed that you can also add a function that provides now and internally has a 'use cache';. Still not ideal, but I believe a better workaround for the time being than having to decorate entry points like layout.tsx.

@amannn amannn changed the title getMessages and getLocale error when experimental.dynamicIO is enabled in Next.js 15.0.2-canary.4 Compatibility of now with experimental.dynamicIO in Next.js canary versions Oct 28, 2024
@amannn
Copy link
Owner

amannn commented Nov 14, 2024

This will be fixed in the upcoming next-intl@4! (#1536)

I've been heads-down exploring implications of dynamicIO with next-intl for the past few days, and I think I finally arrived at a reasonable solution for this case.

For users who don't use relative time formatting, there will no longer be any issues in regard to dynamicIO. For those who do, the next-intl docs will now suggest an approach that allows for granular caching in Server Components or alternatively rendering in Client Components. I think this should provide the best of both worlds.

Updated docs

A first beta version of next-intl@4 should be available soon, this was one of the last items on my list.

Thanks again for opening this issue!

@amannn
Copy link
Owner

amannn commented Dec 23, 2024

This has been resolved in the next-intl 4.0 beta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has-workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants