Skip to content
This repository has been archived by the owner on May 15, 2020. It is now read-only.

simulation_common has incorrect dependency definition #46

Open
AAlon opened this issue Aug 20, 2019 · 1 comment
Open

simulation_common has incorrect dependency definition #46

AAlon opened this issue Aug 20, 2019 · 1 comment

Comments

@AAlon
Copy link
Contributor

AAlon commented Aug 20, 2019

In: https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/blob/master/simulation_ws/src/aws_robomaker_simulation_common/package.xml

The package declares dependency on moveit_ros and dwa_local_planner but it doesn't seem like these are actually used.

On the other hand, the package uses move_base_msgs and geometry_msgs but doesn't declare them as dependencies: https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/blob/master/simulation_ws/src/aws_robomaker_simulation_common/nodes/route_manager#L24

Please audit and fix the dependency definitions.

@mm318
Copy link
Contributor

mm318 commented Feb 6, 2020

The master branch has been renamed to ros1, so the link to the relevant package.xml file is: https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/blob/ros1/simulation_ws/src/aws_robomaker_simulation_common/package.xml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants