Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short UTF-8 Sequences will not be caught if InputStream does not support Length property #101

Open
R-maan opened this issue Mar 30, 2020 · 0 comments
Open

Short UTF-8 Sequences will not be caught if InputStream does not support Length property #101

R-maan opened this issue Mar 30, 2020 · 0 comments
Milestone
Post-GA

Comments

@R-maan
Copy link
Contributor

R-maan commented Mar 30, 2020

Due to the limitation of StreamReader.Read() where it returns -1 if no more characters are available - regardless whether there are any sequence left or not, we are using Stream.Length property to check for short sequences of UTF-8 inputs.

But not all the implementations of Stream will support Length.
If an implementation does not support Length property, short utf-8 sequences will not be caught.
@R-maan R-maan mentioned this issue Mar 30, 2020
Merged
@tgregg tgregg added this to the Post-GA milestone Mar 31, 2020
tgregg pushed a commit that referenced this issue Mar 31, 2020
@R-maan
Fails on too-short UTF-8 sequences consumed from seekable Streams. (#47)
89edf02 
#101 tracks the equivalent fix for non-seekable streams.
@tgregg tgregg mentioned this issue Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Post-GA
Development

No branches or pull requests
2 participants
@tgregg @R-maan