Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp fractional seconds with positive exponent and non zero coefficient should return an error #182

Open
desaikd opened this issue Jun 11, 2021 · 0 comments

Comments

@desaikd
Copy link
Contributor

desaikd commented Jun 11, 2021

PR #181 which addressed the issue #180 didn't include an error when timestamp fractional second has positive exponent and non zero coefficient .

// check if the scale is negative and coefficient is zero then set exponent value to 0
// otherwise set exponent value as per the scale value
if d.scale < 0 && nsec == 0 {
   exponent = uint8(0)  // if nsec != 0 && d.scale < 0 then RETURN AN ERROR
} else {
   exponent = uint8(d.scale)
}

Also, there are no tests in the test harness for timestamp fractional second with positive exponent and non zero coefficient We should add more tests for timestamp fractional seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant