Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using 'string' only to refer to text throughout the APIs #48

Closed
R-maan opened this issue May 29, 2020 · 1 comment
Closed

Using 'string' only to refer to text throughout the APIs #48

R-maan opened this issue May 29, 2020 · 1 comment
Labels
code cleanup Improve the quiality of the code (refactor, other implementation etc.) M Medium T-Shirt size

Comments

@R-maan
Copy link
Contributor

R-maan commented May 29, 2020

Golang allows you to use the string data type to mean "arbitrary bytes", but we should not use it that way.
We should make sure we're only using string to refer to text throughout the APIs.
Mentioned here
@R-maan R-maan mentioned this issue May 29, 2020
Merged
@therapon therapon added code cleanup Improve the quiality of the code (refactor, other implementation etc.) M Medium T-Shirt size labels Jun 8, 2020
This was referenced Aug 19, 2020
Merged
Closed
@R-maan
Copy link
Contributor Author

R-maan commented Sep 18, 2020

I went through the code and didn't see any other instance of this case.

@zslayton, please let me know if you want to double check this or If I can close it.

@zslayton zslayton closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup Improve the quiality of the code (refactor, other implementation etc.) M Medium T-Shirt size
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@therapon @zslayton @R-maan