Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-hash-python uses Ion Nature which was removed since ion-python 0.11.0 #37

Open
cheqianh opened this issue Dec 20, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@cheqianh
Copy link
Contributor

cheqianh commented Dec 20, 2023

Ion Python 0.11.0 dropped the unnecessary factory method and classes such as Ion Nature for performance improvement. Ion Hash Python still uses Ion Nature, which should be dropped.

Currently uses versions that is earlier than 0.10.0 could block this issue.

As a long-term solution, we should drop Ion Nature in ion-hash-python, and have a testing mechanism to ensure that the ion-hash-python uses a desired version of ion-python and functions correct.

@cheqianh cheqianh added the bug Something isn't working label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant