Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sandbox error messages next to the input area with the bad input #84

Open
popematt opened this issue Sep 14, 2022 · 0 comments
Open
Labels
website For issues with the Ion Schema GitHub Pages website (broken links, UI issues, etc.)

Comments

@popematt
Copy link
Contributor

(Suggestion) I think like green(success) and red(danger) should be the colors for valid and invalid validation results respectively.
And yellow(warning) should be used when there is an error in loading the schema or getting the type definition.

Yeah, that's what I had initially, but I thought that invalid inputs to the sandbox (an error) deserved the more "severe" color than data not matching the schema (a non-error).
If I was better with web development, I would prefer to have an error message next to the input area with the bad input, and then we wouldn't have to worry about having the same color for "does not match" and for "user error".

Originally posted by @popematt in #83 (comment)

@popematt popematt added the website For issues with the Ion Schema GitHub Pages website (broken links, UI issues, etc.) label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website For issues with the Ion Schema GitHub Pages website (broken links, UI issues, etc.)
Projects
None yet
Development

No branches or pull requests

1 participant